Skip to content

Commit

Permalink
Refactor/dependency update (#1171)
Browse files Browse the repository at this point in the history
* Bump required node version to 18.13.0 (LTS)
* Update packages besides vite latest which does not yet appear compatible with latest sveltekit
* Add vitest coverage command with v8
* Prettify
* Lint fixes
  • Loading branch information
AaronPlave authored Mar 26, 2024
1 parent fe51930 commit 3827585
Show file tree
Hide file tree
Showing 38 changed files with 5,036 additions and 3,272 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Test (e2e)
run: npm run test:e2e
- name: Test (unit)
run: npm run test:unit
run: npm run test:unit:coverage
- name: Upload Results
if: always()
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.12.0
v18.18.0
1 change: 0 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"arrowParens": "avoid",
"overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }],
"pluginSearchDirs": ["."],
"plugins": ["prettier-plugin-svelte"],
"printWidth": 120,
"semi": true,
Expand Down
5 changes: 3 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
{
"prettier.configPath": "./.prettierrc",
"editor.formatOnSave": true,
"eslint.validate": ["javascript", "typescript", "svelte"],
"[svelte][typescript]": {
"[svelte][typescript][css]": {
"editor.codeActionsOnSave": {
"source.fixAll": "explicit",
"source.organizeImports": "explicit",
"source.sortImports": "explicit"
},
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"stylelint.validate": ["css", "less", "postcss", "svelte"],
"stylelint.validate": ["css", "postcss", "svelte"],
"typescript.preferences.importModuleSpecifier": "relative",
"cSpell.words": ["metadatas", "unconstructable"]
}
5 changes: 4 additions & 1 deletion e2e-tests/fixtures/Constraints.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ export class Constraints {
tableRow: Locator;
tableRowDeleteButton: Locator;

constructor(public page: Page, public models: Models) {
constructor(
public page: Page,
public models: Models,
) {
this.constraintName = uniqueNamesGenerator({ dictionaries: [adjectives, colors, animals] });
this.updatePage(page);
}
Expand Down
6 changes: 5 additions & 1 deletion e2e-tests/fixtures/ExpansionRules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export class ExpansionRules {
tableRow: Locator;
tableRowDeleteButton: Locator;

constructor(public page: Page, public dictionaries: Dictionaries, public models: Models) {
constructor(
public page: Page,
public dictionaries: Dictionaries,
public models: Models,
) {
this.updatePage(page);
}

Expand Down
5 changes: 4 additions & 1 deletion e2e-tests/fixtures/Plans.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export class Plans {
tableRowDeleteButton: Locator;
tableRowPlanId: Locator;

constructor(public page: Page, public models: Models) {
constructor(
public page: Page,
public models: Models,
) {
this.planName = uniqueNamesGenerator({ dictionaries: [adjectives, colors, animals] });
this.updatePage(page);
}
Expand Down
5 changes: 4 additions & 1 deletion e2e-tests/fixtures/SchedulingConditions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ export class SchedulingConditions {
tableRow: Locator;
tableRowDeleteButton: Locator;

constructor(public page: Page, public models: Models) {
constructor(
public page: Page,
public models: Models,
) {
this.conditionName = uniqueNamesGenerator({ dictionaries: [adjectives, colors, animals] });
this.updatePage(page);
}
Expand Down
5 changes: 4 additions & 1 deletion e2e-tests/fixtures/SchedulingGoals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ export class SchedulingGoals {
tableRowDeleteButtonSelector: (goalName: string) => Locator;
tableRowSelector: (goalName: string) => Locator;

constructor(public page: Page, public models: Models) {
constructor(
public page: Page,
public models: Models,
) {
this.updatePage(page);
}

Expand Down
Loading

0 comments on commit 3827585

Please sign in to comment.