Pass PresetId into UpdateRequest

- Remove `id` argument, as it is unused in place of the id already in the `updatedActivityPreset` argument
NASA-AMMOS · Nov 27, 2023 · 9c0ac96 · 9c0ac96
1 parent f9d961a
commit 9c0ac96
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/components/activity/ActivityDirectiveForm.svelte b/src/components/activity/ActivityDirectiveForm.svelte
@@ -251,7 +251,6 @@
     } = event;
     if (activityDirective.applied_preset) {
       await effects.updateActivityPreset(
-        activityDirective.applied_preset.preset_id,
         {
           ...activityDirective.applied_preset.preset_applied,
           arguments: getDisplayedArguments(),

diff --git a/src/utilities/effects.ts b/src/utilities/effects.ts
@@ -3793,20 +3793,18 @@ const effects = {
     }
   },
 
-  async updateActivityPreset(
-    id: ActivityPresetId,
-    updatedActivityPreset: ActivityPresetSetInput,
-    user: User | null,
-  ): Promise<void> {
+  async updateActivityPreset(updatedActivityPreset: ActivityPresetSetInput, user: User | null): Promise<void> {
     try {
       if (!queryPermissions.UPDATE_ACTIVITY_PRESET(user, updatedActivityPreset)) {
         throwPermissionError('update this activity preset');
       }
-      const { id: _id, ...restOfPresetPayload } = updatedActivityPreset;
+
+      const { id: id, ...restOfPresetPayload } = updatedActivityPreset;
       const { update_activity_presets_by_pk } = await reqHasura<ActivityPreset>(
         gql.UPDATE_ACTIVITY_PRESET,
         {
           activityPresetSetInput: restOfPresetPayload,
+          id: id,
         },
         user,
       );