show required attributes

NASA-AMMOS · Jan 3, 2025 · efc7a1d · efc7a1d
1 parent 074e5ef
commit efc7a1d
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/components/external-events/ExternalEventForm.svelte b/src/components/external-events/ExternalEventForm.svelte
@@ -27,6 +27,7 @@
   let externalEventType: ExternalEventType | undefined = undefined;
   let externalEventTypeParametersMap: ParametersMap = {};
   let startTimeField: FieldStore<string>;
+  let requiredAttributes: string[] = [];
 
   $: externalEventType = $externalEventTypes.find(eventType => eventType.name === externalEvent.pkey.event_type_name);
   $: externalEventAttributes = translateJsonSchemaArgumentsToValueSchema(externalEvent.attributes);
@@ -44,6 +45,11 @@
       },
       {} as ParametersMap,
     );
+
+    // Get the set of required attribute names
+    requiredAttributes =
+      $externalEventTypes.find(eventType => eventType.name === externalEvent?.pkey.event_type_name)?.attribute_schema
+        .required ?? [];
   }
 
   $: startTimeField = field<string>(`${formatDate(new Date(externalEvent.start_time), $plugins.time.primary.format)}`);
@@ -101,7 +107,11 @@
           <Parameters
             disabled={true}
             expanded={false}
-            formParameters={getFormParameters(externalEventTypeParametersMap, externalEventAttributes, [])}
+            formParameters={getFormParameters(
+              externalEventTypeParametersMap,
+              externalEventAttributes,
+              requiredAttributes,
+            )}
           />
         </div>
       </Collapse>

diff --git a/src/components/parameters/ParameterInfo.svelte b/src/components/parameters/ParameterInfo.svelte
@@ -20,10 +20,14 @@
   let leaveTimeout: NodeJS.Timeout | null = null;
   let source: ValueSource;
   let unit: string | undefined = undefined;
+  let required: boolean = true;
+  let externalEvent: boolean = false;
 
   $: if (formParameter) {
     source = formParameter.valueSource;
     unit = formParameter.schema?.metadata?.unit?.value;
+    externalEvent = formParameter.externalEvent ?? false;
+    required = formParameter.required ?? true;
   }
 
   function leaveCallback() {
@@ -75,7 +79,7 @@
   }
 </script>
 
-{#if unit || source !== 'none'}
+{#if externalEvent || unit || source !== 'none'}
   <div class="parameter-info-container" role="contentinfo" on:mouseenter={onIconOver} on:mouseleave={onIconOut}>
     <div><InfoIcon /></div>
     <ContextMenu hideAfterClick={false} bind:this={contextMenu}>
@@ -92,6 +96,10 @@
               <ValueSourceBadge {disabled} isCompact={false} {source} on:reset={onReset} />
             </div>
           {/if}
+          {#if externalEvent}
+            <div class="parameter-info-label">Required</div>
+            <div class="parameter-info-value"><i>{required}</i></div>
+          {/if}
         </div>
       </div>
     </ContextMenu>

diff --git a/src/types/parameter.ts b/src/types/parameter.ts
@@ -8,6 +8,7 @@ export type EffectiveArguments = {
 
 export type FormParameter<T = ValueSchema> = {
   errors: string[] | null;
+  externalEvent?: boolean;
   file?: File;
   index?: number;
   key?: string;

diff --git a/src/utilities/parameters.ts b/src/utilities/parameters.ts
@@ -73,6 +73,7 @@ export function getFormParameters(
 
     const formParameter: FormParameter = {
       errors: null,
+      externalEvent: true,
       name,
       order,
       required,