Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make drag handles follow cursor more closely #1003

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Nov 14, 2023

To test:

  1. Create a plan and run a simulation to populate multiple rows
  2. Verify that upon resizing the drag handle always follow the position of the cursor while respecting min/max sizes.
  3. Open the error Console
  4. Verify that resizing also follows the cursor in a similar manner.

@duranb duranb added the refactor A code change that neither fixes a bug nor adds a feature label Nov 14, 2023
@duranb duranb self-assigned this Nov 14, 2023
@duranb duranb requested a review from a team as a code owner November 14, 2023 01:02
@AaronPlave
Copy link
Contributor

Much better! Two comments:

  1. Could you do this for RowHeaderDragHandleWidth.svelte as well?
  2. Seeing the cursor flip between resize and default when dragging row height handles. Looks like that behavior is not from this PR, may be related to the hover+active state styling for home reason not working in this case? And RowHeaderDragHandleWidth is behaving similarly. Any ideas? Could also be addressed in a separate PR, I could take a look too.

@duranb
Copy link
Collaborator Author

duranb commented Nov 14, 2023

Much better! Two comments:

  1. Could you do this for RowHeaderDragHandleWidth.svelte as well?
  2. Seeing the cursor flip between resize and default when dragging row height handles. Looks like that behavior is not from this PR, may be related to the hover+active state styling for home reason not working in this case? And RowHeaderDragHandleWidth is behaving similarly. Any ideas? Could also be addressed in a separate PR, I could take a look too.

Will do! Oh I see the flickering now too. Is this what you were mentioning before? I thought you were talking about the background color flickering.

@duranb
Copy link
Collaborator Author

duranb commented Nov 14, 2023

@AaronPlave the flickering thing might need to be a separate fix

@duranb duranb merged commit 7bc68e5 into develop Nov 14, 2023
@duranb duranb deleted the refactor/drag-handles branch November 14, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants