Display View JSON validation feedback in UploadViewModal #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
changed the title
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
changed the title
duranb
requested changes
Nov 16, 2023
Fixed, ready for a re-test. |
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
fix/947/view-upload-feedback
branch
from
c8561a1 to
871be90
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Display view JSON validation feedback in UploadViewModal. * Disallow pointer events on Collapse svg arrow to prevent conflict when used inside of Modal * Update test
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Display view JSON validation feedback in UploadViewModal. * Disallow pointer events on Collapse svg arrow to prevent conflict when used inside of Modal * Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation feedback to UploadViewModal. Shows success message if view is valid, shows validation errors in a Collapse if present.
Closes #947