Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the number of directives displayed associated with snapshot #1015

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Nov 17, 2023

Currently if you select a snapshot that didn't have any activities associated to it, the displayed number of directives in the plan snapshot bar will display the total directives that exist in the latest revision. This fix ensures that if no directives were present at the time of the snapshot creation, the displayed number of directives will display "0".

To test:

  1. Create plan
  2. Before adding directives, create a snapshot
  3. After a snapshot is created, then add a few
  4. Create another snapshot
  5. Repeat steps 3-4 as many times as you want, but make sure you mentally keep track of how many directives exist during the creation of a snapshot
  6. Open the plan metadata panel and select the very first snapshot
  7. Verify that the plan snapshot bar at the top correctly displays "0 directives"
  8. Click the other snapshots and verify that each one correctly displays the number of directives

@duranb duranb requested a review from a team as a code owner November 17, 2023 00:23
@duranb duranb self-assigned this Nov 17, 2023
@duranb duranb added the fix A bug fix label Nov 17, 2023
@duranb duranb added this to the FY24 Q1 - UI Bug Fixes milestone Nov 17, 2023
@AaronPlave
Copy link
Contributor

The fix here works though seeing a related issue that perhaps should be in a different PR - when I load the first snapshot with no directives the timeline and table still shows the current state of the activities. When I restore the snapshot with no directives it does clear the directives, though the problem reoccurs when I add more directives and repeat the switching of snapshots.

@duranb
Copy link
Collaborator Author

duranb commented Nov 27, 2023

@AaronPlave I think I fixed the issue. It should be ready for another look whenever you have a moment. Thanks!

@duranb duranb force-pushed the fix/incorrect-number-of-snapshot-directives branch from 1597c97 to df821d1 Compare November 28, 2023 01:37
@duranb duranb merged commit 225ba4e into develop Nov 28, 2023
4 checks passed
@duranb duranb deleted the fix/incorrect-number-of-snapshot-directives branch November 28, 2023 02:24
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
)

* also use correct directives to display in table when snapshot is selected
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
)

* also use correct directives to display in table when snapshot is selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants