X-Range performance improvements #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/x-range-perf
branch
from
0bd1fe1 to
7caf9b5
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
jeffpamer
approved these changes
Dec 8, 2023
duranb
approved these changes
Dec 12, 2023
…ont and sizing tweaks.
AaronPlave
force-pushed
the
feat/x-range-perf
branch
from
7caf9b5 to
50af9d5
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Cache x-range text measurements to improve x-range rendering performance * Use Inter for x-range labels
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Cache x-range text measurements to improve x-range rendering performance * Use Inter for x-range labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches x-range text measurements. Drastically improves x-range drawing speed in certain cases. Also changes the x-range font to Inter.
Related to #959.
Test by loading a view with many x-range plots that have multiple different segments. Profile the application and ensure that x-ranges do not spend a long time computing text measurements.