Loading indicator for line and x-range layers #1017
Conversation
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/resource-layer-loading-indicator
branch
from
45fbd84 to
61ff409
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Hold up – not necessarily an issue with this PR but seeing that we're fetching resources and external resources every time the simulation progress updates which causes a flash of the resource loading message. Can see this on Bananation, not sure about other models. Will investigate. |
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/resource-layer-loading-indicator
branch
from
799feef to
f3087ae
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Made some fixes to how we load resources and spans in the plan page to avoid duplicative/unnecessary fetches. Also now aborting stale external resource, resource, and span requests. Ready for re-review. |
There was a problem hiding this comment.
Probably also not related to this PR, but just exposed by it, I'm seeing the loading text show up if I drag a directive but haven't run a simulation yet. The text does eventually go away once everything is downloaded again. I'll leave it up to your discretion if it's something that needs to be addressed. Other than that, I think it's good to go!
Can't reproduce this yet, can you show me once you're back? |
…resource download
…tor. Delay loading indicator by 1 second to prevent flash of content for quick loading resources.
…dates and abort stale requests.
AaronPlave
force-pushed
the
feat/resource-layer-loading-indicator
branch
from
f3087ae to
bb3b1a5
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
* Display a loading indicator when a line or x-range layer is awaiting resource download * Consider external resource loading when presenting row loading indicator. Delay loading indicator by 1 second to prevent flash of content for quick loading resources. * Fix redundant resource and span fetches during simulation progress updates and abort stale requests.
* Display a loading indicator when a line or x-range layer is awaiting resource download * Consider external resource loading when presenting row loading indicator. Delay loading indicator by 1 second to prevent flash of content for quick loading resources. * Fix redundant resource and span fetches during simulation progress updates and abort stale requests.
Display a loading indicator on a row when the row has at least one layer and resources are loading. Abort stale resource requests and avoid unnecessary refetching of resources.