Initial pass at adding a toggle to show mode changes as a line chart #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
|
Looks like |
It's calling the correct |
|
One thing that would be really useful here would be to draw the horizontal ticks as is done for line layers. Think that could go in this PR or want to split it into a new ticket? |
I was looking into this a little yesterday afternoon, I can see if it's viable quickly for this PR otherwise I'll add it to the next ticket. |
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
reviewed
Dec 5, 2023
src/components/timeline/form/TimelineEditorLayerSettings.svelte
Outdated
Show resolved
Hide resolved
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
d8431c1 to
3132520
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
reviewed
Dec 7, 2023
AaronPlave
reviewed
Dec 7, 2023
AaronPlave
reviewed
Dec 11, 2023
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
e2316fc to
2c986d2
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
2c986d2 to
1f885d8
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
d0d5af1 to
473ad27
Compare
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
reviewed
Dec 19, 2023
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
5acdefb to
e2ffd64
Compare
…ips and showing variants
cohansen
force-pushed
the
feature/mode-changes-as-line-chart
branch
from
e2ffd64 to
6e3bb02
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
…1025) * Initial pass at adding a toggle to show mode changes as a line chart * Removed unused categorical checker and an older comment * Moved state mode changes out of LayerXRange and into LayerLine * Added the new property to the ui-view schema * Changed view property to show as line plot, fixed an issue with tooltips and showing variants * Added the separator back and fixed the resizing issue for the axis label * Added totalWidth sum back and fixed more issues with latest merge * Fixed an issue where multiple axis were not being shown * Fixed another issue when drawing multiple xRange layers inside of a single row * Removed link between xrange layer and axis * Fixed an issue with only showing the first xrange axis label
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
…1025) * Initial pass at adding a toggle to show mode changes as a line chart * Removed unused categorical checker and an older comment * Moved state mode changes out of LayerXRange and into LayerLine * Added the new property to the ui-view schema * Changed view property to show as line plot, fixed an issue with tooltips and showing variants * Added the separator back and fixed the resizing issue for the axis label * Added totalWidth sum back and fixed more issues with latest merge * Fixed an issue where multiple axis were not being shown * Fixed another issue when drawing multiple xRange layers inside of a single row * Removed link between xrange layer and axis * Fixed an issue with only showing the first xrange axis label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #640.
This is the first pass at showing mode changes as a line chart similar to how Raven works.
There's more work to go on this issue, right now horizontal rules aren't working properly and the correct way to implement this is to generate a new type of Y axes which we're not currently doing.