Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle to autosize activity table columns #1031

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add toggle to autosize activity table columns #1031

merged 4 commits into from
Nov 30, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Nov 29, 2023 •
edited
Loading

Resolves #346

To test:

  1. Create a plan
  2. Add some directives and run a successful simulation
  3. Verify that resizing the window or panel will cause the activity table columns to auto fit to the available space
  4. Resize a column
  5. Verify that resizing no longer auto fits the columns
  6. Click on the auto size button to toggle it back on
    Screenshot 2023-11-29 at 2 55 38 PM
  7. Verify that resizing the window once again auto resizes the columns

@duranb duranb added the refactor A code change that neither fixes a bug nor adds a feature label Nov 29, 2023
@duranb duranb self-assigned this Nov 29, 2023
@duranb duranb requested a review from a team as a code owner November 29, 2023 22:57
@duranb duranb force-pushed the refactor/auto-size-default-table branch from 982d501 to 0dae993 Compare November 30, 2023 19:28
AaronPlave
AaronPlave approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@duranb duranb merged commit a39cd78 into develop Nov 30, 2023
4 checks passed
@duranb duranb deleted the refactor/auto-size-default-table branch November 30, 2023 21:35
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Add toggle to autosize activity table columns (#1031)
55d6c41 
* save auto resize state to view
* auto size on column toggle for directives
* auto size on column toggle for spans
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @JosephVolosin
Add toggle to autosize activity table columns (#1031)
2d344e5 
* save auto resize state to view
* auto size on column toggle for directives
* auto size on column toggle for spans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@duranb duranb

Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Aerie
Status: Done
Milestone
FY24 Q1 - UI Ad Hoc Improvements
Development

Successfully merging this pull request may close these issues.

Confirm that current table design is sufficient or if automatic resizing is still needed
2 participants
@duranb @AaronPlave