Make it possible to cancel an in-progress simulation #1032
Conversation
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
This will be so useful! Not something we need to do in this PR but wonder if we should have a visual indicator on the timeline for when a sim was canceled so that it's obvious that the lack of data in certain places is due to sim cancelation and not some sort of gap? Though perhaps if you cancel a sim you don't really care about sim results? If we decide to do anything about this then it should also play into whatever we do for streaming sim results.. |
There was a problem hiding this comment.
This is awesome! My one concern is choice of icon to cancel or maybe its placement. To me it looks like it's a "close" button and clicking it would get rid of the current simulation from the UI altogether. Maybe if you hover over "in progress", it shows "cancel"?
We could also try using a proper cancel button, like a circle with a slash through it? Would need to add such an icon to Stellar. Or a stop icon And one note - the close icon was actually there before this PR since it also applies to canceling pending sims. |
Ooooh. My bad. I still think that the icon might be misleading, but I'll let you @mattdailis decide whether or not that gets updated in this PR or another effort or if it's worth updating at all. |
|
One thing I'm noticing which could just be how the backend works now is that if i queue up a bunch of simulations (past the number of available workers) the pending sims will stay pending until a worker completes a sim and then all pending sims except for the latest one will be marked as failed. I'm assuming this is somewhat similar to the old behavior where pending sims that were outdated would be auto canceled? In any case, seems odd to mark them as failed in the UI here, wondering how we should handle this? |
|
Another issue that could be in a separate PR is that sims are cancelable during plan snapshot preview |
mattdailis
force-pushed
the
feat/cancel-in-progress-simulation
branch
from
946002b to
1a6c915
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
I can make this icon! |
mattdailis
force-pushed
the
feat/cancel-in-progress-simulation
branch
from
1a6c915 to
62daa74
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
There was a problem hiding this comment.
Other than the feedback that @AaronPlave left, I think this works great! Thank you!
|
@mattdailis also if you want to disable the button if it's in plan preview, there's a |
joswig
modified the milestones:
FY24 Q1 - UI Ad Hoc Improvements,
FY24 Q2 - UI Ad Hoc Improvements
mattdailis
force-pushed
the
feat/cancel-in-progress-simulation
branch
from
90a29a4 to
f145d7e
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
force-pushed
the
feat/cancel-in-progress-simulation
branch
from
f145d7e to
810a194
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
* Make it possible to cancel an in-progress simulation * Handle simulations canceled after finishing * Update stellar and tweak button css * Fix package.json lint error * Disable cancel buttons when plan is read only
* Make it possible to cancel an in-progress simulation * Handle simulations canceled after finishing * Update stellar and tweak button css * Fix package.json lint error * Disable cancel buttons when plan is read only
We previously implemented the ability to cancel pending simulations. As of a week or two ago, the backend now supports canceling in-progress simulations. This PR moves around a few if statements in the UI code to:
CanceledifsimulationDataset.canceledreasonfieldScreen.Recording.2023-11-29.at.3.58.07.PM.mov