Fix concurrent test worker login failure #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
added
the
refactor
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Nov 30, 2023
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Use global setup and teardown strategies to only login once for e2e tests
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Use global setup and teardown strategies to only login once for e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple workers login simultaneously it introduces a conflict where the backend attempts to create multiple users with the same username. Instead of having each worker login this PR refactors e2e tests so that login is performed once in global setup, stored in an auth file for the e2e tests, and then removed during teardown. See https://playwright.dev/docs/test-global-setup-teardown. This should make tests less flaky though certain tests may still be flaky for unrelated reasons.