-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line layer decimation, interpolation, snapping, and tooltip improvements #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
December 8, 2023 00:31 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
December 8, 2023 00:35
2c313fc
to
59a887e
Compare
AaronPlave
temporarily deployed
to
test-workflow
December 8, 2023 00:35 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 8, 2023 16:18 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
December 11, 2023 19:39
97833ba
to
d012496
Compare
AaronPlave
temporarily deployed
to
test-workflow
December 11, 2023 19:40 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 11, 2023 21:06 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 11, 2023 21:40 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 11, 2023 21:52 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
December 13, 2023 00:43
e5ddcdc
to
f04b627
Compare
AaronPlave
temporarily deployed
to
test-workflow
December 13, 2023 00:43 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 13, 2023 01:16 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 13, 2023 23:56 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 19, 2023 22:50 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 20, 2023 18:14 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 20, 2023 20:15 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
December 21, 2023 20:37
f172ae1
to
b8a2e67
Compare
AaronPlave
temporarily deployed
to
test-workflow
December 21, 2023 20:37 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
December 21, 2023 21:57 — with
GitHub Actions
Inactive
AaronPlave
changed the title
Feat/decimation prototyping
Line layer decimation, interpolation, snapping, and tooltip improvements
Dec 27, 2023
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
January 16, 2024 21:54
e95d23d
to
a911a95
Compare
AaronPlave
temporarily deployed
to
test-workflow
January 16, 2024 21:54 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
January 24, 2024 19:17 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/decimation-prototyping
branch
from
February 15, 2024 17:20
8452d83
to
07edc67
Compare
AaronPlave
temporarily deployed
to
test-workflow
February 15, 2024 17:20 — with
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
…nts (#1049) * Line chart decimation option using client-side min-max algorithm * Only render line points within time view plus neighboring left/right points * Rework line point hit testing and snapping to improve usability * Improve highlighted point legibility * Remove resource id from tooltip * Improve timeline tooltip styling and display * Option to hide timeline tooltip * Allow null for LinePoint y value * Improve line hover value intersection * Option to interpolate cursor value when hovering over line charts * Hint points to left and right of interpolated point * Integrate decimation and interpolation into x-range as line layer rendering * Defer scaling points until after decimation for non-ordinal line layers. * Update stellar version * Implement new timeline icon tray and menu
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
…nts (#1049) * Line chart decimation option using client-side min-max algorithm * Only render line points within time view plus neighboring left/right points * Rework line point hit testing and snapping to improve usability * Improve highlighted point legibility * Remove resource id from tooltip * Improve timeline tooltip styling and display * Option to hide timeline tooltip * Allow null for LinePoint y value * Improve line hover value intersection * Option to interpolate cursor value when hovering over line charts * Hint points to left and right of interpolated point * Integrate decimation and interpolation into x-range as line layer rendering * Defer scaling points until after decimation for non-ordinal line layers. * Update stellar version * Implement new timeline icon tray and menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource plot decimation and hover value interpolation. Significantly improves resource plotting performance and resource tooltip behavior.
Changes:
Closes #856, closes #959. Multiple PRs have addressed the #959 but with this PR, performance targets have been achieved for the Clipper TT-6 plan.
TODO: