-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh simulation results after scheduling #1055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6af16aa
to
0babfad
Compare
duranb
requested changes
Dec 13, 2023
0babfad
to
a5b8124
Compare
a5b8124
to
320bdb2
Compare
320bdb2
to
8012a2d
Compare
8012a2d
to
45764ea
Compare
45764ea
to
34cc4a8
Compare
duranb
reviewed
Dec 18, 2023
34cc4a8
to
5e5cdf4
Compare
duranb
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you!
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
Refresh results after scheduling
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Refresh results after scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling almost always stores its latest simulation results into the database and returns the corresponding dataset id so the user does not have to simulate yet another time. In this PR, I get this id, convert it to a simulation dataset id, and update the corresponding shared variable so that the views are updated with the latest dataset.
Thank you @duranb for the help.