Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh simulation results after scheduling #1055

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

adrienmaillard
Copy link
Contributor

Scheduling almost always stores its latest simulation results into the database and returns the corresponding dataset id so the user does not have to simulate yet another time. In this PR, I get this id, convert it to a simulation dataset id, and update the corresponding shared variable so that the views are updated with the latest dataset.

Thank you @duranb for the help.

src/utilities/gql.ts Outdated Show resolved Hide resolved
src/utilities/gql.ts Outdated Show resolved Hide resolved
src/utilities/effects.ts Show resolved Hide resolved
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from 0babfad to a5b8124 Compare December 14, 2023 22:01
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from a5b8124 to 320bdb2 Compare December 14, 2023 22:05
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from 320bdb2 to 8012a2d Compare December 14, 2023 22:14
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from 8012a2d to 45764ea Compare December 14, 2023 22:22
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from 45764ea to 34cc4a8 Compare December 18, 2023 16:51
src/utilities/effects.ts Outdated Show resolved Hide resolved
@adrienmaillard adrienmaillard force-pushed the refresh-sim-results-after-scheduling branch from 34cc4a8 to 5e5cdf4 Compare December 18, 2023 16:57
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you!

@adrienmaillard adrienmaillard merged commit a15bda7 into develop Dec 18, 2023
4 checks passed
@adrienmaillard adrienmaillard deleted the refresh-sim-results-after-scheduling branch December 18, 2023 18:35
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants