Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take "out of plan bounds" activities into account in total count display #1066

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Dec 27, 2023

Resolves #1058

To test:

  1. Create a plan and add any number of activities
  2. Select an activity
  3. Edit the anchor of the activity to be a negative duration relative to plan start
  4. Verify that the nav bar now displays a "1" for the activity status.

@duranb duranb requested a review from a team as a code owner December 27, 2023 18:18
@duranb duranb self-assigned this Dec 27, 2023
@duranb duranb added the fix A bug fix label Dec 27, 2023
@AaronPlave
Copy link
Contributor

AaronPlave commented Dec 27, 2023

Interestingly if I anchor an activity to the out of bounds activity from the repro steps the problem count remains at 1 even though the second anchored activity is also out of bounds. Though maybe this is actually coming from the API so no change would be needed in this PR?

Edit: I'm not able to always reproduce this, seems fairly particular. Do see it happening if you have a directive negatively anchored to plan and then anchor another directive to that first one with a positive offset to the parent directive. When you set the offset to negative on the child directive, validation will correctly state that the child directive is out of bounds. But when positive, the validation thinks that child is in bounds.

Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed an issue in aerie related to my comment, otherwise LGTM.

@duranb
Copy link
Collaborator Author

duranb commented Dec 27, 2023

Filed an issue in aerie related to my comment, otherwise LGTM.

Thank you!

@duranb duranb merged commit e1bf4cb into develop Dec 27, 2023
4 checks passed
@duranb duranb deleted the fix/1058-invalid-activity-counts branch December 27, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Invalid Anchors aren't counted in Activity Errors Navbar Badge
2 participants