Fix/734/external dataset loading #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also filter out duplicate entries in the timeline editor resources list? Though I'm fine with that being a separate PR too. |
Done! |
AaronPlave
reviewed
Jan 3, 2024
AaronPlave
reviewed
Jan 3, 2024
AaronPlave
reviewed
Jan 3, 2024
AaronPlave
reviewed
Jan 3, 2024
… use its own flag
AaronPlave
reviewed
Jan 4, 2024
AaronPlave
approved these changes
Jan 4, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Fix external resource fetching sim dataset id argument. * Added a query just to get external dataset names to populate view modification * Remove duplicate resource names * Added a type for our external dataset query and modified the query to use its own flag * Removed fetchingResourcesExternalNames for now --------- Co-authored-by: Aaron Plave <[email protected]>
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Fix external resource fetching sim dataset id argument. * Added a query just to get external dataset names to populate view modification * Remove duplicate resource names * Added a type for our external dataset query and modified the query to use its own flag * Removed fetchingResourcesExternalNames for now --------- Co-authored-by: Aaron Plave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #734.
This PR fixes behavior around loading external datasets that aren't attached to a simulation, and also only loads the name for the timeline editor so it doesn't hang while trying to load all the profiles.