Display username in app menu #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Jan 3, 2024
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
approved these changes
Jan 5, 2024
Agreed. The menu supports the option of not closing on click but then you do have to handle closing the menu manually when you click on any of those menu items. Needs a bit of thinking on what we want the API to look like there. |
AaronPlave
force-pushed
the
feat/1019/username-in-app-menu
branch
from
f3f14f3 to
235871e
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Display username in app menu
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Display username in app menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1019 by displaying the username in the app menu.
@lklyne feel free to take a pass at this one if you'd like or provide input on tweaks / a different location or presentation.