Fix constraint violations display

[mattdailis]

Bug Description

1. Upload banananation
2. Make a plan that's a week long
3. Add a GrowBanana activity. Set itsgrowingDuration to 3d and its quantity to 1000
4. Add the following constraint

export default (): Constraint => {
  return Real.Resource("/fruit").greaterThan(500)
}

5. Open the constraint panel
6. Check constraints
7. Observe that the navbar says there are violations, and that there are red violation counts in the constraints panel, but that no red regions are highlighted on the timeline, and no violations appear when expanding the violation details in the constraints panel.

Recommended fix

A detailed reading of #1022 shows that some of the reactive variables related to constraints were rerouted, leading to some transformations to be left out of the pipeline. Concretely, the $constraintResult variable was previously responsible for translating constraint violations windows from "offset from plan start in microseconds" to "milliseconds since the unix epoch". After the above PR, this translation was no longer occurring, leading to downstream confusion.

This PR removes the $constraintResult variable entirely, moving that transformation into the $constraintResponseMap reactive variable. Any constraint code must be derived from $constraintResponseMap, without reaching around it to use the un-processed constraintResponses. To this end, this PR renames constraintResponse to rawConstraintResponses (pluralized to reflect plural usage elsewhere in the code), to hopefully make it harder to make that mistake.

textForConstraintViolation was using a brittle approach to try to find the constraint response corresponding to the given violation. This PR instead threads the constraintName through to the usage of this function, so that it can do its job without relying on global variables. This is why a number of uses of ConstraintResult were updated to ConstraintResultWithName.

Lastly, this PR changes the label in the constraints nav bar. According to the Constraints panel, a single constraint can contain many violations. The nav bar, however, only counts the number of constraints violated, and does not sum up the total number of violations. To this end, this PR rewords "Constraint violations: 5" to instead read "Constraints violated: 5"

[duranb]

works great! thanks a bunch!