Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add retrigger model extraction #1349

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Feature/add retrigger model extraction #1349

merged 9 commits into from
Jul 1, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jun 25, 2024 •
edited
Loading

Resolves #1326

Depends on:

Aerie Gateway endpoint: NASA-AMMOS/aerie-gateway#93
Aerie Backend: NASA-AMMOS/aerie#1467

To test:

  1. Go to model creation page
  2. Stop the aerie_merlin container
  3. Create a model
  4. Verify that an error is displayed for the newly created model
  5. Start up the aerie_merlin container
  6. After aerie_merlin has started up, click on the refresh icon next to the "Jar file status"
    Screenshot 2024-06-25 at 8 33 51 AM
  7. Verify that the error on the model goes away

@duranb duranb requested a review from a team as a code owner June 25, 2024 15:34
@duranb duranb temporarily deployed to test-workflow June 27, 2024 21:10 — with GitHub Actions Inactive
AaronPlave
AaronPlave approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM other than a minor comment

@duranb duranb force-pushed the feature/add-retrigger-model-extraction branch from 5bfead8 to e90f678 Compare July 1, 2024 18:28
@duranb duranb temporarily deployed to test-workflow July 1, 2024 18:29 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow July 1, 2024 18:54 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow July 1, 2024 19:02 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow July 1, 2024 19:07 — with GitHub Actions Inactive
@duranb duranb merged commit c9dbcdb into develop Jul 1, 2024
5 checks passed
@duranb duranb deleted the feature/add-retrigger-model-extraction branch July 1, 2024 19:16
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Feature/add retrigger model extraction (#1349)
f2077aa 
* update model "extracting" logic
* use gateway endpoint to retrigger model extraction
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @JosephVolosin
Feature/add retrigger model extraction (#1349)
ca4f57c 
* update model "extracting" logic
* use gateway endpoint to retrigger model extraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to retrigger mission model extraction from UI
2 participants
@duranb @AaronPlave