Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/loading indicators part 1 #1589

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Feat/loading indicators part 1 #1589

wants to merge 3 commits into from

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Jan 3, 2025 •
edited
Loading

Partially addresses #1581

Changes:

  • DataGrid and super-component loading prop to control the ag-grid loading message
  • DataGrid skeleton loading component
  • Update various subscriptions to be some list OR null in order to detect when a subscription has not initialized (TODO document which stores)
  • Track initial load of simulation arguments and display loading message
  • Style bug fix for plan loading where several absolutely positioned timeline elements were not relative to the correct parent and were causing overflow after SSR and before UI interactivity

@AaronPlave AaronPlave self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AaronPlave