Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zooming improvements #960

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Zooming improvements #960

merged 10 commits into from
Oct 26, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Oct 24, 2023

resolves #826

To test:

  1. Create a plan and add some directives and run the simulation to populate the resources
  2. Right click anywhere on a resource
  3. Hover over the new "Zoom" sub menu
  4. Choose a zoom level
  5. Verify that the time range centers on where you right clicked and that the time range is now the zoom level that was chosen

@duranb duranb self-assigned this Oct 24, 2023
@duranb duranb requested a review from a team as a code owner October 24, 2023 18:32
@duranb duranb temporarily deployed to test-workflow October 24, 2023 18:32 — with GitHub Actions Inactive
@duranb duranb added the feature New feature or request label Oct 24, 2023
@duranb duranb temporarily deployed to test-workflow October 24, 2023 20:26 — with GitHub Actions Inactive
@AaronPlave AaronPlave temporarily deployed to test-workflow October 25, 2023 18:54 — with GitHub Actions Inactive
duranb added 2 commits October 25, 2023 12:27
@duranb
cleanup
866cf9d
@duranb
clamp time range on context menu zoom
e8f0bee 
center around pivot point on zoom
@duranb duranb temporarily deployed to test-workflow October 25, 2023 19:28 — with GitHub Actions Inactive
@duranb
remove zoom minimum
36a690d 
add ability to zoom on selected directive
@duranb duranb temporarily deployed to test-workflow October 25, 2023 21:10 — with GitHub Actions Inactive
@duranb
update zoom options in context menu
0938ee8 
update zoom out to be the opposite
@duranb duranb temporarily deployed to test-workflow October 25, 2023 23:15 — with GitHub Actions Inactive
AaronPlave
AaronPlave approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duranb duranb merged commit 1c93b69 into develop Oct 26, 2023
4 checks passed
@duranb duranb deleted the feat/zooming-improvements branch October 26, 2023 00:16
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb @AaronPlave
Zooming improvements (#960)
0501abb 
* add context menu to all timeline row layers
* center around pivot point on zoom
* add ability to zoom on selected directive

---------

Co-authored-by: Aaron Plave <[email protected]>
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @AaronPlave @JosephVolosin
Zooming improvements (#960)
34d6af1 
* add context menu to all timeline row layers
* center around pivot point on zoom
* add ability to zoom on selected directive

---------

Co-authored-by: Aaron Plave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@duranb duranb

Labels
feature New feature or request
Projects
Aerie
Status: Done
Milestone
FY24 Q1 - Activity UI improvements pa...
Development

Successfully merging this pull request may close these issues.

Difficult to zoom into a small portion of a large plan
3 participants
@duranb @AaronPlave @dandelany