-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline density improvements and refactoring #977
Conversation
61bc2c3
to
6897c34
Compare
6897c34
to
4afba1f
Compare
4e1aa8d
to
d9da164
Compare
fc627a0
to
8389baf
Compare
…s. Layer name overrides resource name in row header if present. Add copy-able tooltip to row header resource label.
eee3627
to
9c06571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @AaronPlave! Tested all of the features mentioned above with no major issues - all of my notes are minor & totally optional nitpicks/improvements:
-
Small z-index bug - when you hover over the Y axis legend label on a line chart row AND that row is selected, the row boundary line shows above the tooltip
-
Would be nice to have some better handling for naming copies of copies, by duplicating rows you can easily end up with "My row (copy) (copy) (copy)"
-
When dragging row edges to resize, rows have a minimum height and minimum left margin (now the header area). These minimums aren't enforced if you edit the height/margin using the number input the Timeline Editor panel, and probably should be - otherwise you can accidentally end up with a very small row
-
The new row context menu is nice! It makes me want a slight extension of it - if you right click below the last row, it would be nice to have a context menu with a shortcut to add a new row
Fixed, good catch!
Agreed but will punt on this.
Implemented.
One issue here is that if your rows take up more than the available height there will be no additional room below the last row. How would you feel about adding an "Insert row" context menu option that is always available?
|
Seems reasonable to me! 👍 |
* Display plan time bounds in DOY format to the left of the timeline histogram. * Refactor timeline x axis time visualization to display dynamically formatted UTC and user local time. * Display row header and controls in the left column of the row instead of horizontally stacking the header. * Resize row header (i.e. marginLeft in the timeline view settings, TODO rename this?) by clicking and dragging on the right side of the row header column. * Move row drag handle to the middle of uncollapsed row headers, allow users to also drag rows from the row title. * Row option to show only activity directives. * Improve row dragging styles. * Resolve row jitter bug. * Render line and x-range plots when rows are collapsed. * Display heatmap of directives and/or spans for collapsed activity layers. * Change row y-axis ticks to use a dotted line. * Move y-axes to within the row header and separate them using vertical lines. * Enforce the user's tick count number as defined in the view instead of using the normal d3 method which only takes tick count as a suggestion. * Color y-axis tick values by resource color if a single resource is associated with the axis. * Three dot menu in row header with row actions (Edit Row, Move Up/Down, Duplicate Row, Delete Row, Show Simulated Activities/Directives/Both, Insert Row). * Right click row header context menu with row actions. * Display resource names under row titles and color using layer color. * Format y axis tick values using SI-prefixes.
* Display plan time bounds in DOY format to the left of the timeline histogram. * Refactor timeline x axis time visualization to display dynamically formatted UTC and user local time. * Display row header and controls in the left column of the row instead of horizontally stacking the header. * Resize row header (i.e. marginLeft in the timeline view settings, TODO rename this?) by clicking and dragging on the right side of the row header column. * Move row drag handle to the middle of uncollapsed row headers, allow users to also drag rows from the row title. * Row option to show only activity directives. * Improve row dragging styles. * Resolve row jitter bug. * Render line and x-range plots when rows are collapsed. * Display heatmap of directives and/or spans for collapsed activity layers. * Change row y-axis ticks to use a dotted line. * Move y-axes to within the row header and separate them using vertical lines. * Enforce the user's tick count number as defined in the view instead of using the normal d3 method which only takes tick count as a suggestion. * Color y-axis tick values by resource color if a single resource is associated with the axis. * Three dot menu in row header with row actions (Edit Row, Move Up/Down, Duplicate Row, Delete Row, Show Simulated Activities/Directives/Both, Insert Row). * Right click row header context menu with row actions. * Display resource names under row titles and color using layer color. * Format y axis tick values using SI-prefixes.
Improves the density of the timeline through re-organization of the layout and the addition of various new features.
Changes:
Other TODOs:
Closes #954
Closes #443
Closes #453
Closes #746