Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure getPlanTags returns an array if no tags found #987

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

AaronPlave
Copy link
Contributor

Closes #978

@AaronPlave AaronPlave requested a review from a team as a code owner November 7, 2023 17:34
@AaronPlave AaronPlave self-assigned this Nov 7, 2023
@AaronPlave AaronPlave added the fix A bug fix label Nov 7, 2023
src/utilities/effects.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave merged commit d7ce881 into develop Nov 9, 2023
4 checks passed
@AaronPlave AaronPlave deleted the fix/978/plan-tags-safety branch November 9, 2023 18:38
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Fix how tags are pulled out of the getPlanTags effect response.
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Fix how tags are pulled out of the getPlanTags effect response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close Snapshot Button stops working after Role Change when using View
2 participants