Cancel a Scheduling Run #1251
Merged
Cancel a Scheduling Run #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
breaking change
adrienmaillard
approved these changes
Dec 7, 2023
...ler-worker/src/main/java/gov/nasa/jpl/aerie/scheduler/worker/SchedulingCanceledListener.java
Outdated
Show resolved
Hide resolved
- Scheduling will check if it has been canceled: - before computing simulation results - before processing a batch in simulation - before initializing the plan - at the top of `satisfyGoal` - at the top of `removeAndInsertActivitiesFromSimulation` - If it has been canceled, it will throw a `SchedulingInterruptedException`, which will bubble up until it hits the `SynchronousSchedulerAgent`, which will catch it and report the simulation as canceled.
- Make uploading the Foo Jar a method on GatewayRequests - Change bad status from Simulation/Scheduling from an IOException to fail()
Mythicaeda
force-pushed
the
feat/cancel-scheduling
branch
from
b85cd93 to
f1f82b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for a scheduling run to be canceled.
Scheduling will check if it has been canceled:
satisfyGoalremoveAndInsertActivitiesFromSimulationIf it has been canceled, it will throw a
SchedulingInterruptedException, which will bubble up until it hits theSynchronousSchedulerAgent, which will catch the exception and report the scheduling run as canceled.Unlike with simulation, partial results are not returned.
Verification
schedulesyntax. All of them have been set to uncancelable.reasoncolumn.Documentation
No docs need to be updated.
Future work
UI needs to be updated to allow for canceling an in-progress Scheduling Run