Added ability to specify a rate for a SampledResource #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdailis
reviewed
May 30, 2023
contrib/src/main/java/gov/nasa/jpl/aerie/contrib/models/SampledResource.java
Outdated
Show resolved
Hide resolved
contrib/src/main/java/gov/nasa/jpl/aerie/contrib/models/SampledResource.java
Show resolved
Hide resolved
contrib/src/main/java/gov/nasa/jpl/aerie/contrib/models/SampledResource.java
Outdated
Show resolved
Hide resolved
contrib/src/main/java/gov/nasa/jpl/aerie/contrib/models/SampledResource.java
Outdated
Show resolved
Hide resolved
mattdailis
approved these changes
May 31, 2023
contrib/src/main/java/gov/nasa/jpl/aerie/contrib/models/SampledResource.java
Outdated
Show resolved
Hide resolved
ewferg
force-pushed
the
contrib-sampl-res-update
branch
from
8789e70 to
9921c3a
Compare
camargo
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example SampledResource in the contrib package was a little too simple in that it did not provide the capability to sample at a user specified rate. This PR updates the SampledResource so that users can both initialize a resource to a custom sample rate and change the rate later if they wish.
Verification
No tests were added and the original resource constructor still exists, which defaults the rate to one second.
Documentation
The Resource and Models section of the docs should be updated, but my plan was to address this update as part of NASA-AMMOS/aerie-docs#46