Bump core openmct dependency #184
Conversation
update core to v3.2.0
| let component; | ||
| let _destroy = null; | ||
|
|
||
| const table = new FrameWatchTable(domainObject, this.openmct, this.options, this.type); | ||
|
|
||
| const view = { |
There was a problem hiding this comment.
can we call this currentView?
| enable: true, | ||
| useAlternateControlBar: false, | ||
| rowName: '', | ||
| rowNamePlural: '' | ||
| }; | ||
|
|
||
| const view = { |
There was a problem hiding this comment.
can we name this currentView?
| element: document.createElement('div'), | ||
| priority: -1 | ||
| }; | ||
| const renderWhenVisible = func => { |
There was a problem hiding this comment.
Do we use this anywhere else? should we make it a util?
| @@ -14,12 +14,11 @@ export default class PacketQueryViewProvider { | |||
| } | |||
|
|
|||
| view(domainObject, objectPath) { | |||
| let component; | |||
| let _destroy = null; | |||
|
|
|||
| const view = { | |||
There was a problem hiding this comment.
can we change this to currentView
| let component; | ||
| let _destroy = null; | ||
|
|
||
| const table = new PacketSummaryTable(domainObject, openmct); | ||
|
|
||
| const view = { |
There was a problem hiding this comment.
can we change this to currentView?
| enable: true, | ||
| useAlternateControlBar: false, | ||
| rowName: '', | ||
| rowNamePlural: '' | ||
| }; | ||
|
|
||
| const view = { |
There was a problem hiding this comment.
Lots of great work here! Lots!
Left some comments/suggestions. Let's talk about the openmct vs this.openmct situation. There also seem to be a good amount of "Unused Variable" notifications for items returned from mount that we could get rid of.
Awesome work!
Thanks. yes we should make the |
|
New issue to address |
|
Closes #137 , #132, #164
bump to
5.3.0-next