Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable "Real-time Connection Lost" Notification #190

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Configurable "Real-time Connection Lost" Notification #190

merged 2 commits into from
Oct 11, 2024

Conversation

chesterhawkins
Copy link
Contributor

@chesterhawkins chesterhawkins commented Aug 12, 2024 •
edited by davetsay
Loading

Closes #177

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jvigliotta jvigliotta added this to the MC2412 Sprint 5 milestone Aug 23, 2024
@jvigliotta jvigliotta changed the title Replaced the connection lost blocking dialog with a console warn and … Configurable "Real-time Connection Lost" Notification Aug 26, 2024
@jvigliotta jvigliotta mentioned this pull request Aug 26, 2024
Closed
@davetsay davetsay removed this from the MC2412 Sprint 5 milestone Sep 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chesterhawkins
Copy link
Contributor Author

@davetsay Updated from warnings to errors

@jvigliotta jvigliotta self-requested a review October 11, 2024 22:46
jvigliotta
jvigliotta approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @chesterhawkins ! Thanks for this.

@jvigliotta jvigliotta merged commit c8c126e into NASA-AMMOS:main Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Real-time data connection lost dialog is blocking and asks users to reload which may not be necessary
3 participants
@chesterhawkins @jvigliotta @davetsay