-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unit Tests] Update unit tests #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I have a couple comments inline.
Did all the other tests pass? I thought for sure the data product cell tests broke as a result of vue upgrade. Did we fix those elsewhere?
|
||
import MCWSUserContainerProvider from '../MCWSUserContainerProvider'; | ||
import MCWSPersistenceProvider from '../MCWSPersistenceProvider'; | ||
import mcws from '../../services/mcws/mcws'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use the defined path 'services/mcws/mcws'
}; | ||
import MCWSPersistenceProvider from '../MCWSPersistenceProvider'; | ||
import MCWSUserContainerProvider from '../MCWSUserContainerProvider'; | ||
import mcws from '../../services/mcws/mcws'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use the defined path 'services/mcws/mcws'
}) | ||
}); | ||
import MCWSPersistenceProvider from '../MCWSPersistenceProvider'; | ||
import mcws from '../../services/mcws/mcws'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use the defined path 'services/mcws/mcws'
}); | ||
|
||
// DO WE DELETE THIS TEST? I don't think we use this functionality anymore. | ||
xit('provides a listing of namespaces when provided a namespace definition', async (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do call getNamespacesFromMCWS
so maybe this is still an okay unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look.
I'll look... I thought that was one of the first one's I did. |
…ersistence update error return
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link to an issue. Also, create issues to back fill the tests that were x-ed out, the window mocking one and the vue components ones. We should still retain the same unit test coverage and deprecate only when we get e2e test coverage.
closes #259
Updates unit tests broken during updates/upgrades.