Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Governance Models for Different Team Sizes #139

Closed
wants to merge 20 commits into from

Conversation

riverma
Copy link
Collaborator

@riverma riverma commented Jan 23, 2024

Purpose

  • SLIM already has a default governance model recommendation here but it needs some rework for prime time.
  • In this PR, we are proposing two new governance models, one for medium and one for smaller sized teams to have a total of three governance model recommendations. We'd also like more community input on best practice governance approaches.

Proposed Changes

  • [ADD] Small and medium sized team governance models
  • [CHANGE] Renamed the role "collaborators" to "committers"

Issues

Testing

@riverma riverma requested review from a team January 23, 2024 01:02
@riverma
Copy link
Collaborator Author

riverma commented Jan 23, 2024

NOTE: I'd like to propose (after merging this) to apply the new "Medium Size Team" template (sample here) to the SLIM Governance Model, which would mean combining the SLIM TSC and PSC.

@riverma riverma self-assigned this Jan 23, 2024
@riverma riverma added the governance Process improvements involving coordinating, delegating, estimating, organizing / running projects label Jan 23, 2024
@riverma
Copy link
Collaborator Author

riverma commented Jan 29, 2024

Some feedback received so far:

  • How do the roles defined get mapped to GitHub Teams? Should we offer guidance or automation there?
  • Maybe three tiers of governance is too much, can we get away with just two? i.e. large and small projects?

@jpl-jengelke
Copy link
Contributor

jpl-jengelke commented Feb 15, 2024

Some feedback received so far:

  • How do the roles defined get mapped to GitHub Teams? Should we offer guidance or automation there?
  • Maybe three tiers of governance is too much, can we get away with just two? i.e. large and small (move medium to small?) projects?

I feel we should do large and small and skip over medium. Someone can integrate parts of large if they want to extend the small group model.

On that note, I think all SLIM example repos should default to the small model.

Copy link
Contributor

@jpl-jengelke jpl-jengelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the proviso that we should limit the models to two -- medium (renamed small) and large.

@riverma riverma requested a review from a team February 23, 2024 01:52
@PaulMRamirez
Copy link
Collaborator

Consider adding a diagram of a suggest path to merit. Apache Software Foundation has such an example https://training.apache.org/presentations/comdev/apache-intro/#/path-of-merit.

Another consideration is at times for medium or large teams a project could chose a governance where the path to merit is sped up by having Committers automatically put onto the Steering Committee. This is just an option and a decision to be made by those that adopt one of these governance models.


Subset of contributors who have been given write access to one or more project repositories. Both contributors and collaborators can propose changes to the project via pull requests, but only collaborators can formally review and approve (merge) these requests. Any contributor who has made a non-trivial contribution should be on-boarded as a collaborator in a timely manner.
Subset of contributors who have been given write access to one or more project repositories. Both contributors and committer can propose changes to the project via pull requests, but only committers can formally review and approve (merge) these requests. Any contributor who has made a non-trivial contribution should be on-boarded as a committer in a timely manner.
Copy link

@thomas-bc thomas-bc Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment that I made internally (see Slack thread) about the following:

Any contributor who has made a non-trivial contribution should be on-boarded as a committer in a timely manner.

Some open-source projects might be very touchy about allowing write permissions to external contributors. Branch protection and permissions can be set in place to alleviate some concerns, but there's always a non-zero risk. For example, through allowing arbitrary commits on the main repo's branches, one could be concerned about this indirectly allowing external contributors to execute arbitrary code on self-hosted GitHub Action runners, if the repo has any.

@riverma suggested this new phrasing, which I personally really like:

Any contributor who has made a non-trivial contribution should be considered as a candidate for the committer role by the steering committee or the product manager.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @thomas-bc and your suggestions! Will incorporate the new phrasing 👍

@riverma
Copy link
Collaborator Author

riverma commented Feb 28, 2024

Consider adding a diagram of a suggest path to merit. Apache Software Foundation has such an example https://training.apache.org/presentations/comdev/apache-intro/#/path-of-merit.

Another consideration is at times for medium or large teams a project could chose a governance where the path to merit is sped up by having Committers automatically put onto the Steering Committee. This is just an option and a decision to be made by those that adopt one of these governance models.

💯 that @PaulMRamirez - great suggestion for adding a visual. I'll incorporate that.

@riverma
Copy link
Collaborator Author

riverma commented Jul 29, 2024

Re-opening this PR as work has not finished.

@riverma riverma reopened this Jul 29, 2024
@riverma
Copy link
Collaborator Author

riverma commented Aug 30, 2024

Closing in place of: #170

@riverma riverma closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance Process improvements involving coordinating, delegating, estimating, organizing / running projects
Projects
Status: ✅ Work Complete
Development

Successfully merging this pull request may close these issues.

4 participants