-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web based Cognito authentication for Nucleus Airflow UI #137
base: main
Are you sure you want to change the base?
Conversation
@ramesh-maddegoda can we investigate these hotspots found by SonarCloud? Also generate a new secrets detection baseline for that failed workflow? |
Refer to issue: #123
@jordanpadams , I did the secret detection 2 times and pushed the new baselines. I am investigating more. |
@ramesh-maddegoda I'll fix the |
@nutjob4life and @jordanpadams , It seems the issues reported are not due to secrets. Those are terraform related suggestions. I am improving those areas. |
thanks @ramesh-maddegoda. in addition to the secrets tool, if you could go into the sonarcloud tool and audit/close these issues with a comment describing why these are not an issue that would be great. |
Let me know if you have any questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions otherwise looking pretty good!
terraform/terraform-modules/cognito-auth/lambda/requirements.txt
Outdated
Show resolved
Hide resolved
terraform/terraform-modules/cognito-auth/lambda/requirements.txt
Outdated
Show resolved
Hide resolved
|
@jordanpadams , All SonarCube findings are resolved with code changes or with comments (example: a false positive related with using an unverified JWT token, while we actually verify the token few code lines after). In overall, that is a very helpful analysis!. |
🗒️ Summary
Web based Cognito authentication for Nucleus Airflow UI. This implementation is based on the AWS Technical Guide
Accessing a private Amazon MWAA environment using federated identities
♻️ Related Issues
Web based Cognito authentication for Nucleus Airflow UI