Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 50: TrustManager that accepts all certificates #117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jordanpadams
Copy link
Member

Fixes https://github.com/NASA-PDS/registry-common/security/code-scanning/50

To fix the problem, we need to replace the insecure TrustAllManager with a more secure implementation that only trusts specific certificates. This can be achieved by using a KeyStore to load the trusted certificates and initializing a TrustManagerFactory with this KeyStore. This ensures that only the specified certificates are trusted, mitigating the risk of man-in-the-middle attacks.

  1. Create a KeyStore and load the trusted certificates into it.
  2. Initialize a TrustManagerFactory with the KeyStore.
  3. Use the TrustManagerFactory to get the TrustManagers.
  4. Initialize the SSLContext with these TrustManagers.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ficates

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant