remove refernces to clamp from clamp of fail

Fail has been ignored for some time, only clamp is used. #624
NCAR · Mar 6, 2025 · c8077df · c8077df
1 parent 83c8b69
commit c8077df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/models/mpas_atm/model_mod.f90 b/models/mpas_atm/model_mod.f90
@@ -110,7 +110,7 @@ module model_mod
 use netcdf
 
 use state_structure_mod, only :  add_domain, get_model_variable_indices, &
-                                 state_structure_info, get_index_start, get_index_end, &
+                                 get_index_start, get_index_end, &
                                  get_num_variables, get_domain_size, get_varid_from_varname, &
                                  get_variable_name, get_num_dims, get_dim_lengths, &
                                  get_dart_vector_index, get_num_varids_from_kind, &
@@ -298,7 +298,7 @@ module model_mod
 
 integer, parameter :: MAX_STATE_VARIABLES = 80
 integer, parameter :: NUM_STATE_TABLE_COLUMNS = 2
-integer, parameter :: NUM_BOUNDS_TABLE_COLUMNS = 4 !HK @todo get rid of clamp or fail
+integer, parameter :: NUM_BOUNDS_TABLE_COLUMNS = 3
 character(len=vtablenamelength) :: variable_table(MAX_STATE_VARIABLES, NUM_STATE_TABLE_COLUMNS )
 
 !------------------------------------------------------------------------
@@ -1727,9 +1727,6 @@ subroutine verify_state_variables(ncid, filename, ngood, qty_list, variable_boun
    call nc_check(NF90_inq_varid(ncid, trim(varname), VarID), &
                  'verify_state_variables', trim(string2))
 
-   ! Make sure variable is defined by (Time,nCells) or (Time,nCells,vertical)
-   ! unable to support Edges or Vertices at this time.m !HK @todo this is not true.
-
    call nc_check(nf90_inquire_variable(ncid, VarID, dimids=dimIDs, ndims=numdims), &
                  'verify_state_variables', 'inquire '//trim(string1))
 

diff --git a/models/mpas_atm/readme.rst b/models/mpas_atm/readme.rst
@@ -289,8 +289,8 @@ mpas_vars_nml
                              'qv',                    'QTY_VAPOR_MIXING_RATIO',
                              'qc',                    'QTY_CLOUDWATER_MIXING_RATIO',
                              'surface_pressure',      'QTY_SURFACE_PRESSURE'
-      mpas_state_bounds    = 'qv','0.0','NULL','CLAMP',
-                             'qc','0.0','NULL','CLAMP',
+      mpas_state_bounds    = 'qv','0.0','NULL'
+                             'qc','0.0','NULL'
    /
 
 **mpas_state_variables**
@@ -302,7 +302,6 @@ mpas_vars_nml
 
  - The first column must match the exact NetCDF field name in the MPAS file.
  - The second and third columns are the minimum and maximum values for the field.
- - The fourth column is ignored.
 
 
 ``mpas_state_bounds`` is for variables with fixed minimum or maximum limits. 

diff --git a/models/mpas_atm/work/input.nml b/models/mpas_atm/work/input.nml
@@ -211,13 +211,12 @@
                           'qv',                    'QTY_VAPOR_MIXING_RATIO',
                           'surface_pressure',      'QTY_SURFACE_PRESSURE',
                           't2m'                    'QTY_2M_TEMPERATURE',
-   mpas_state_bounds    = 'qv','0.0','NULL','CLAMP',
+   mpas_state_bounds    = 'qv','0.0','NULL',
   /
 
 &update_mpas_states_nml
   update_input_file_list  = 'filter_out.txt'
   update_output_file_list = 'filter_in.txt'
-  print_data_ranges      = .true.
   /
 
 &update_bc_nml