-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified wrf/wrf-chem model_mod #741
Open
hkershaw-brown
wants to merge
11
commits into
main
Choose a base branch
from
wrf-unified
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New model_mod directory so development can happen concurrently on wrf and wrf_unified. Original pull request #683
will add back as needed
For un reviewed atmos-chem forward operators see #743 |
The wrf-dart shell scripts are in the wrf/shell_scripts directory This runme_filter script is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactored WRF model mod for WRF & WRF CHEM.
Namelist selectable QTYS, see #404 for details.
Created a wrf_unified model directory. This is to allow concurrent development on wrf and wrf_unified.
wrf_unified/model_mod is ~4500 less than the wrf/model_mod and this is a bit of a headache for keeping up-to-date with main (easy to miss changes in such differing code).
See pull #683 for original pull request
wrf-wrf-chem branch available at https://github.com/hkershaw-brown/DART/tree/wrf-wrf-chem
Fixes issue
Fixes #404
Partial #359 (WRF)
Partial #624 (WRF)
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Bitwise tests during refactoring
Checklist for merging
Checklist for release
Testing Datasets