-
Notifications
You must be signed in to change notification settings - Fork 64
CCPP Framework Meeting Minutes 2025 02 05
Attendees: Michael Kavulich, Dom Heinzeller, Jordan Powers, Cheryl Craig, RhaeSung Kim, Dustin Swales, Grant Firl, Soren Rasmussen, Courtney Peverley, Jesse Nusbaumer
CCPP Framework (issues, PRs, discussions)
-
Enable multiple schemes to use the same local name for different variables #621
- Any updates?
-
- Approved, but looks like Steve was still going to make some changes?
-
Capgen in SCM: Bug fix for scheme ordering in non-run phases #629
- Merged, surprised this has never caused trouble before!
-
Allow for multiple instances of local_name in Cap. Issue#630
-
Capgen in SCM: Multiple instances of local_name in Group Cap #631
- Just one suggestion and one question, otherwise looks ready to go
-
Capgen in SCM: Multiple instances of local_name in Group Cap #631
-
Sub-cycling not working properly Issue#632, Suite-part list is wrong Issue#634
-
Capgen in SCM: Fix to allow for scheme subcycling. #633
- For merge after #631
-
Capgen in SCM: Fix to allow for scheme subcycling. #633
-
Update main with develop branch #638
- Merged, is testing status okay?
-
Code Valor: high-impact violation in ccpp_prebuild code generator Issue#641
-
Testing refactor #612
- Continued discussion
Standard names (issues, PRs, discussions)
-
- Just need one final update from Jerome and then ready to merge.
-
- Comments addressed, waiting for feedback
Offer suggestions/comments on development workflow rules:
Mike: I have disabled merge commits since it is too easy to accidentally commit them that way. There have been two changes to develop that were not squashed in the past two months. It's easy enough to re-enable them temporarily when merging in main
.
CCPP Framework
- Ed Hartnett unit testing
- Dom pushed back; we need to wait for Michael W’s test refactor to be complete anyway
- Michael to create an issue from the discussion
- MPI interface
- Used by JEDI
- Will keep to just wrapping broadcast calls
- Will be optional, but we’ll see how many developers use it
- Multiple local names in group cap
- Cheryl & Courtney to take a look
- Differing source and module name
- Design questions
- Possible future work of new class (beyond scheme, host) that’s parsed first
- Dustin to open an issue
- Design questions
- Update main with develop branch
- Merged, but UFS hasn’t tested yet
- Dom suggests updating template w/ check boxes for each organization
- Michael to look into this
- DDT subfields in group caps
- Dustin to move to draft until PR it’s based on is merged
- Remove execute function from common.py (prebuild)
- Dustin to look at, Michael K to merge
Standard Names
- Almost ready to merge Jerome’s emissions names (#86)
- XML and metadata still out of sync
- v1 rules update
- Michael K addressed Dom & Steve’s comments
- Needs more eyes; Jesse to take a look next week
- Michael will change name to “ESMStandardNames” on 2/13
Discussion
- Squash vs merge discussion
- Michael K to look at new github branch rules
- General agreement with Michael K’s decision to disable merge commits and then enable them to merge to main
- Dustin - in group caps, argument lists are really long
- In debug mode/intel, intel complained about too many arguments (255)
- Dom - if some schemes want full ddt, and some schemes want just some fields, are we passing both?
- We should ONLY pass the DDTs
- Hard limit for arguments - might work to override
- Somehow works in non-debug mode, though
- Soren testing flags, Dustin to look into repercussions of adding the flag in the UFS
- Michael - people have been asking about standard names governance
- Who’s going to be a member?
- Someone from ESMF team should be involved - Ann Tsay is the ESMF lead
- Who’s going to be a member?