Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1174 followup #727

Merged
merged 2 commits into from
Jan 23, 2025
Merged

1174 followup #727

merged 2 commits into from
Jan 23, 2025

Conversation

amber-emmes
Copy link
Contributor

Home mouthwash kit now defaults to physical address if provided at all, vs. only when mailing address is a PO Box, as per notes on 1174.

…l, vs. only when mailing address is a PO Box
@amber-emmes amber-emmes requested review from a team January 23, 2025 18:29
@amber-emmes amber-emmes self-assigned this Jan 23, 2025
@amber-emmes amber-emmes requested review from we-ai and bransteitterbr and removed request for a team January 23, 2025 18:29
Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove settings used for local tests, if the settings conflict with production code.

utils/firestore.js Outdated Show resolved Hide resolved
@amber-emmes amber-emmes requested a review from we-ai January 23, 2025 18:59
Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.


// If there is a physical address, default to it unless it's a PO Box
// (Behavior clarified in the notes on [1174](https://github.com/episphere/connect/issues/1174))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link!

@amber-emmes amber-emmes merged commit e59181c into dev Jan 23, 2025
2 checks passed
@amber-emmes amber-emmes deleted the 1174-followup branch January 23, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants