Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evsrestapi 423] filter source #246

Merged
merged 4 commits into from
Apr 26, 2024
Merged

[evsrestapi 423] filter source #246

merged 4 commits into from
Apr 26, 2024

Conversation

gaaliciA1990
Copy link
Contributor

@gaaliciA1990 gaaliciA1990 commented Apr 24, 2024 •
edited
Loading

Implementing changes to avoid pull the normName and stemName from being shown when reading the object.

  1. Added tests to confirm normName and stemName aren't returned for the concept and synonyms
  2. Removed access = Access.READ_ONLY from normName and stemName` in the Concept model. Left the annotation in the Synonym model.
  3. Updated some SearchControllerTests to ensure deboost is still pulling RetiredConcepts, but sorting them to the end of the list.

@gaaliciA1990 gaaliciA1990 marked this pull request as ready for review April 24, 2024 17:46
@gaaliciA1990
Copy link
Contributor Author

tag created, v2024-04-25-1.10.0.RELEASE. Ready to be build and deployed for testing.

bcarlsenca
bcarlsenca approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@bcarlsenca bcarlsenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging

@bcarlsenca bcarlsenca merged commit ba0d6e5 into develop Apr 26, 2024
1 check passed
@bcarlsenca bcarlsenca deleted the alg/EVSRESTAPI-423-FilterSource branch April 26, 2024 23:06
@gaaliciA1990 gaaliciA1990 changed the title Alg/evsrestapi 423 filter source [evsrestapi 423] filter source Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcarlsenca bcarlsenca bcarlsenca approved these changes

@peter-va peter-va Awaiting requested review from peter-va

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaliciA1990 @bcarlsenca