Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pva/evsrestapi 412 implement obib #249

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Pva/evsrestapi 412 implement obib #249

merged 8 commits into from
Apr 30, 2024

Conversation

peter-va
Copy link
Collaborator

@peter-va peter-va requested a review from bcarlsenca April 30, 2024 05:36
gaaliciA1990
gaaliciA1990 reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gaaliciA1990 gaaliciA1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests cover use cases.

bcarlsenca
bcarlsenca approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@bcarlsenca bcarlsenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bcarlsenca bcarlsenca merged commit f29cf19 into develop Apr 30, 2024
1 check passed
@peter-va peter-va deleted the pva/EVSRESTAPI-412-implement-obib branch June 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaliciA1990 gaaliciA1990 gaaliciA1990 left review comments

@bcarlsenca bcarlsenca bcarlsenca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-va @bcarlsenca @gaaliciA1990