Pva/evsrestapi 539 add pediatric subsets #319
Conversation
| workbook.close(); // Close the workbook to release resources | ||
| } catch (IOException e) { | ||
| System.err.println("Failed to close the workbook. Error: " + e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Never use this pattern of having a try/catch and then just logging the error. In this case, just define the methdo as "throws Exception" and let it just get thrown. If there's really a problem here, we should stop. This is probably true of the try on 629 also. Why bother even catching it - just let that exception get thrown. The other option is to catch the exception, then do a logger.error("your own error message",e); and then throw new Exception("Unexpected xxx",e)
There was a problem hiding this comment.
Catching it I think is going to be important for the audit log later (so I can record the necessary information for the error), so I'll throw the exception after catching it
| @@ -0,0 +1,161 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are we adding this file here? is it for testing? Because this file lives in evsrestapi-operations and having it here is confusing. We should add "extra subsets" to the real file in evsrestapi-operations.
There was a problem hiding this comment.
This is there because we talked about having the test for reading extraSubsets from the json file use a local version of the file instead of the operations version. I can change that back to the operations version without much trouble if that's better
…ogy-runtimes Pva/evsrestapi 542 index terminology runtimes
Implements pediatric subsets, integrating them into the subset hierarchy under the NCIt subset C143048
https://tracker.nci.nih.gov/browse/EVSRESTAPI-539