Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove article-id from uu disclaimer #565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katrinewi
Copy link
Contributor

Fjerner article-id fra uu-disclaimer, tror dette er alt som trengs? 🤔

@katrinewi katrinewi force-pushed the uu-disclaimer-embed-updates branch from 29d62a8 to 1a2073a Compare December 16, 2024 14:55
@katrinewi katrinewi marked this pull request as ready for review December 16, 2024 15:02
@gunnarvelle
Copy link
Member

Gjorde noen stikkprøver og ser at det er en del uu-disclaimere med artikkelid. Kanskje vi skulle konvertert desse til artikkelnivå-disclaimere med ndlaembed-lenke? Bør sjekke med ndla om det er greit om vi berre sletter.

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Vi bør vel også lage en liten pr til ed som fjerner setting av artikkel i uu-disclaimer?

@katrinewi
Copy link
Contributor Author

LGTM. Vi bør vel også lage en liten pr til ed som fjerner setting av artikkel i uu-disclaimer?

Har en på vei! avventer å merge denne til den er klar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants