Merge pull request #2663 from NDLANO/fix/do-not-fall-back-to-empty-sr…

…c-string fix: do not fall back to empty src string
NDLANO · Jan 3, 2025 · 7eff1eb · 7eff1eb
2 parents 14e4431 + 5ab6797
commit 7eff1eb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/ndla-ui/src/Embed/ExternalEmbed.tsx b/packages/ndla-ui/src/Embed/ExternalEmbed.tsx
@@ -49,7 +49,7 @@ const ExternalEmbed = ({ embed }: Props) => {
 
   if (embedData.type === "fullscreen") {
     const image = {
-      src: data.iframeImage?.image.imageUrl ?? "",
+      src: data.iframeImage?.image.imageUrl,
       alt: embedData.alt !== undefined ? embedData.alt : (data.iframeImage?.alttext?.alttext ?? ""),
     };
     return (

diff --git a/packages/ndla-ui/src/Embed/IframeEmbed.tsx b/packages/ndla-ui/src/Embed/IframeEmbed.tsx
@@ -48,7 +48,7 @@ const IframeEmbed = ({ embed }: Props) => {
   if (embedData.type === "fullscreen") {
     const iframeImage = embed.status === "success" ? data.iframeImage : undefined;
     const alt = embedData.alt !== undefined ? embedData.alt : iframeImage?.alttext.alttext;
-    const image = { src: iframeImage?.image.imageUrl ?? "", alt: alt ?? "" };
+    const image = { src: iframeImage?.image.imageUrl, alt: alt ?? "" };
     return (
       <Figure data-embed-type="iframe">
         <ResourceBox

diff --git a/packages/ndla-ui/src/ResourceBox/ResourceBox.tsx b/packages/ndla-ui/src/ResourceBox/ResourceBox.tsx
@@ -66,7 +66,7 @@ const StyledText = styled(Text, {
 });
 
 interface ImageMeta {
-  src: string;
+  src: string | undefined;
   alt: string;
 }
 

diff --git a/packages/ndla-video-search/src/VideoListItem.tsx b/packages/ndla-video-search/src/VideoListItem.tsx
@@ -110,7 +110,7 @@ export const VideoListItem = ({ video, onVideoSelect, translations, locale }: Vi
   return (
     <li>
       <StyledListItemRoot context="list" nonInteractive>
-        <StyledImage src={video.images?.thumbnail?.src ?? ""} alt="" variant="rounded" />
+        <StyledImage src={video.images?.thumbnail?.src} alt="" variant="rounded" />
         <StyledListItemContent>
           <StyledVideoMeta>
             <Text textStyle="title.medium">