UU-Disclaimer embed updates #2659
Conversation
katrinewi
force-pushed
the
disclaimer-embed-updates
branch
from
28c4c3d to
e842a11
Compare
katrinewi
force-pushed
the
disclaimer-embed-updates
branch
from
e842a11 to
02a477e
Compare
katrinewi
force-pushed
the
disclaimer-embed-updates
branch
from
6bb2f0c to
7e501a6
Compare
katrinewi
force-pushed
the
disclaimer-embed-updates
branch
from
17b695b to
8c15da5
Compare
|
Kan sikkert ta inn denne og publisere pakker. Eksisterende kode vil jo ikkje påvirkes av nye versjoner her. |
| @@ -15,7 +15,10 @@ import { type PluginType } from "../types"; | |||
| export const uuDisclaimerEmbedPlugin: PluginType = (element, opts, transformOpts) => { | |||
| const props = attributesToProps(element.attribs); | |||
| const data = JSON.parse(props["data-json"] as string) as UuDisclaimerMetaData; | |||
| const transformedDisclaimer = transform(data.embedData.disclaimer, transformOpts); | |||
| if (data.status === "error") { | |||
| return null; | |||
There was a problem hiding this comment.
Burde vi ha bedre errorhåndtering her? vurderte å legge til støtte for uu-disclaimer i EmbedErrorPlaceholder, innspill?
There was a problem hiding this comment.
Synes det høres lurt ut, jeg. Evt bare vise innhold direkte?
katrinewi
force-pushed
the
disclaimer-embed-updates
branch
from
08ce135 to
abf854d
Compare
| const props = attributesToProps(element.attribs); | ||
| const data = JSON.parse(props["data-json"] as string) as UuDisclaimerMetaData; | ||
| return <UuDisclaimerEmbed embed={data}>{domToReact(element.children as DOMNode[], opts)}</UuDisclaimerEmbed>; | ||
| if (data.status === "error") { | ||
| return <>{domToReact(element.children as DOMNode[], opts)}</>; |
There was a problem hiding this comment.
Trenger vi et fragment her?
There was a problem hiding this comment.
Jepp, ellers blir TS sinna pga return typen til funksjonen
| }, | ||
| }); | ||
|
|
||
| const UuDisclaimerEmbed = ({ embed, children }: Props) => { | ||
| const UuDisclaimerEmbed = ({ embed, transformedDisclaimer, children }: Props) => { |
There was a problem hiding this comment.
Vil vi fortsatt returnere ingenting dersom disclaimer har feil?
There was a problem hiding this comment.
Hmm hva med å returnere innholdet også vise en feilmelding over eller noe?
| aria-label={t("uuDisclaimer.title")} | ||
| title={t("uuDisclaimer.title")} |
There was a problem hiding this comment.
Jeg mistenker at disse vil bli satt av PopoverTitle automatisk. Kan det stemme?
There was a problem hiding this comment.
Jeg tror ikke det, ser dårlig ut
https://github.com/NDLANO/Issues/issues/4245
relatert: NDLANO/graphql-api#528
Tilhørende PR i ed kommer også