Drop sending chromeos errors to sentry #2293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
reviewed
Jan 6, 2025
jnatten
reviewed
Jan 6, 2025
| @@ -16,26 +16,46 @@ const isInformationalError = (exception: unknown): boolean => { | |||
| }; | |||
|
|
|||
| const sentryIgnoreErrors = [ | |||
| // Network problems | |||
| "Failed to fetch", | |||
There was a problem hiding this comment.
Kan ikke denne bli litt "catch-all"-y?
Ser for meg at vi kunne laget en feil som er "Failed to fetch xyz because of this and that" som ikke ville blitt med siden denne fanger alle feil som inneholder denne teksten?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Var masse nye feil i sentry som ser ut til å komme fra chromeos.