Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new search #2296

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: new search #2296

wants to merge 6 commits into from
+2,068 −2,385

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Jan 6, 2025 •
edited
Loading

TODO:

  • Loading-skeleton
  • Loading-indikator for pågående søk
  • Suggestions
  • Finne ut av hvordan ressurstype-filter skal funke
  • Drøfte fag i vanlig søk
  • Fjerne gammel kode :D
  • Rename ting som avventer sletting av gammel kode
  • Nynorsk-sjekk av oversettelser
  • Flytte LTI over på ny søkeside
  • Flytte fokus til toppen ved paginering
  • Penere subject-parametre i URL (droppe urn:subject:)

@Jonas-C Jonas-C force-pushed the feat/new-search branch 4 times, most recently from 4eb499a to cd24b1c Compare February 12, 2025 12:10
gunnarvelle
gunnarvelle reviewed Feb 13, 2025
View reviewed changes
@gunnarvelle
Copy link
Member

Første pagineringsklikk på Neste fører deg til page=1 med søkeresultat 2 til 10

@gunnarvelle
Copy link
Member

Nytt søk gir deg ingen mulighet til å få treff utenfor taksonomi, siden du enten sender inn topic-article eller liste med resourceTypes. For å få til det må du nesten sende inn contextType=standard og så berre sende resourceTypes dersom nokon faktisk velger en slik.

Jonas-C
Jonas-C commented Feb 13, 2025
View reviewed changes
src/containers/SearchPageV2/GrepFilter.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Koden som er kommentert ut i denne filen har å gjøre med visning av navn og beskrivelse av KM/KE, og skal kanskje inn igjen.

@katrinewi
Copy link
Contributor

Burde sidetall resettes når man endrer filter/søket?

@katrinewi
Copy link
Contributor

Virker ikke som treff som vises ved siden av checkboksene samsvarer med faktisk antall søketreff?

@katrinewi
Copy link
Contributor

Mobilvisning burde fikses 😅 pagination overflower :(

@gunnarvelle gunnarvelle requested a review from ghveem February 13, 2025 09:10
@gunnarvelle
Copy link
Member

Ser du over oversettelsestekster @ghveem ?

ghveem
ghveem reviewed Feb 13, 2025
View reviewed changes
ghveem
ghveem requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@ghveem ghveem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Håpar det er forståeleg.
nb: linje 68, 70, 79, 100

katrinewi
katrinewi reviewed Feb 13, 2025
View reviewed changes
@Jonas-C Jonas-C force-pushed the feat/new-search branch 4 times, most recently from 8988553 to 54306a2 Compare February 13, 2025 13:24
@Jonas-C Jonas-C force-pushed the feat/new-search branch 6 times, most recently from fe63a4f to 0160b17 Compare March 11, 2025 15:06
Jonas-C
Jonas-C commented Mar 12, 2025
View reviewed changes
src/containers/SearchPage/GrepFilter.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kommentert ut kode er "gammel" visning av grep-koder. Dersom vi går for den forenklede versjonen fjerner jeg det.

@Jonas-C Jonas-C marked this pull request as ready for review March 12, 2025 09:04
@Jonas-C Jonas-C requested a review from a team March 12, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarvelle gunnarvelle gunnarvelle left review comments

@katrinewi katrinewi katrinewi left review comments

@ghveem ghveem ghveem requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonas-C @gunnarvelle @katrinewi @ghveem