Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace with fromEventOutsideAngular in other places #8998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Feb 2, 2025

No description provided.

Copy link

zorro-bot bot commented Feb 2, 2025

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (d70a768) to head (ae5a47d).

Files with missing lines Patch % Lines
components/tabs/tab-scroll-list.directive.ts 86.66% 2 Missing ⚠️
...ts/table/src/table/table-inner-scroll.component.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8998   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         555      555           
  Lines       19708    19692   -16     
  Branches     2946     2947    +1     
=======================================
- Hits        18118    18104   -14     
+ Misses       1263     1262    -1     
+ Partials      327      326    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119
Copy link
Collaborator

Please fix the test :)

@HyperLife1119 HyperLife1119 added PR: unreviewed PR: target-patch PR: need-test Test is necessary for code changes. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: need-test Test is necessary for code changes. PR: target-patch PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants