Role management endpoints #145

LuisDuarte1 · 2023-04-05T14:48:01Z

Closes #79

Adds various endpoints for role management, such as:

Add/remove roles
Gets all roles
Get a specific role
Add/remove users from a role
Grant/Revoke permissions from a role
Add/remove activities that are associated with a role
Add/remove permissions on PerActivityRoles

github-actions · 2023-04-05T14:53:18Z

Check the documentation preview: https://642d8b5ae9a57b4c25c78bd5--niaefeup-backend-docs.netlify.app

codecov-commenter · 2023-04-05T14:53:36Z

Codecov Report

Patch coverage: 90.52% and project coverage change: +2.33 🎉

Comparison is base (0a5b495) 88.49% compared to head (a17fe90) 90.82%.

❗ Current head a17fe90 differs from pull request most recent head 09ee6c4. Consider uploading reports for the commit 09ee6c4 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #145      +/-   ##
=============================================
+ Coverage      88.49%   90.82%   +2.33%     
- Complexity       345      393      +48     
=============================================
  Files             61       65       +4     
  Lines            791      916     +125     
  Branches          65       75      +10     
=============================================
+ Hits             700      832     +132     
+ Misses            57       40      -17     
- Partials          34       44      +10

Impacted Files	Coverage Δ
.../up/fe/ni/website/backend/service/ErrorMessages.kt	`85.71% <33.33%> (-5.20%)`	⬇️
...pt/up/fe/ni/website/backend/service/RoleService.kt	`86.58% <89.23%> (+69.19%)`	⬆️
...fe/ni/website/backend/controller/RoleController.kt	`100.00% <100.00%> (ø)`
.../website/backend/dto/permissions/PermissionsDto.kt	`100.00% <100.00%> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-04-05T14:55:28Z

Check the documentation preview: https://642d8bdd7b8e354bb1f7061d--niaefeup-backend-docs.netlify.app

BrunoRosendo · 2023-04-16T16:26:21Z

Is it ready for review?

github-actions · 2023-04-26T15:16:05Z

Check the documentation preview: https://64494031ea2fff069ea42bf3--niaefeup-backend-docs.netlify.app

BrunoRosendo

Good job so far! I know I wrote a lot of comments but the functionalities are there and seem to work as expected! A lot of the comments are about small things like documentation and code suggestions

src/main/kotlin/pt/up/fe/ni/website/backend/controller/RoleController.kt

src/test/kotlin/pt/up/fe/ni/website/backend/controller/RoleControllerTest.kt

Co-authored-by: BrunoRosendo <[email protected]>

src/main/kotlin/pt/up/fe/ni/website/backend/controller/RoleController.kt

github-actions · 2023-07-05T13:54:58Z

Check the documentation preview: https://64a5762f1e76480aacf54ba7--niaefeup-backend-docs.netlify.app

limwa

Almost there! I just marked some comments that haven't been properly dealt with and one other suggestions!

src/main/kotlin/pt/up/fe/ni/website/backend/controller/RoleController.kt

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt

BrunoRosendo · 2023-07-25T19:41:58Z

Please change this in the generation service too:

website-niaefeup-backend/src/main/kotlin/pt/up/fe/ni/website/backend/service/GenerationService.kt

Line 92 in 0c670a9

    
           private fun assignRolesAndActivities(generation: Generation, dto: GenerationDto) {

I commented the lines where I defined both sides of the relationship

BrunoRosendo

I just noticed we don't have a way of updating some role fields, such as name and isSection. We can discuss that in the next meeting

BrunoRosendo · 2023-07-25T19:37:47Z

.../kotlin/pt/up/fe/ni/website/backend/utils/documentation/payloadschemas/model/PayloadRoles.kt

+    Tag.ROLES,
+    mutableListOf(
+        DocumentedJSONField("name", "Name of the role", JsonFieldType.STRING),
+        DocumentedJSONField("permissions", "Permissions in the role, as an integer", JsonFieldType.ARRAY),


You may want to open an issue for that and CC him

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt

BrunoRosendo · 2023-07-25T20:42:50Z

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt

+        role.generation = generation
+        generation.roles.add(role)


Only the generation side is necessary

without the generation side it doesn't work for some reason :/

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt

src/test/kotlin/pt/up/fe/ni/website/backend/utils/TestUtils.kt

github-actions · 2023-07-26T15:00:01Z

Check the documentation preview: https://64c134edc956871187f2c84d--niaefeup-backend-docs.netlify.app

limwa

LGTM 🚀

BrunoRosendo · 2023-08-08T01:31:55Z

I just noticed we don't have a way of updating some role fields, such as name and isSection. We can discuss that in the next meeting

@LuisDuarte1 I only want to discuss this in a meeting, I forgot last time

github-actions · 2023-08-16T11:47:38Z

Check the documentation preview: https://64dcb75697ed715c4dab4f17--niaefeup-backend-docs.netlify.app

LuisDuarte1 · 2023-08-16T12:12:01Z

I just noticed we don't have a way of updating some role fields, such as name and isSection.

Done

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt

github-actions · 2023-08-16T15:26:43Z

Check the documentation preview: https://64dceaaf583dbb275aaa12e6--niaefeup-backend-docs.netlify.app

github-actions · 2023-08-16T15:34:12Z

Check the documentation preview:

LuisDuarte1 added 4 commits April 5, 2023 15:41

Add role repository

7717b40

Add RoleService and logic related to role modification

7773353

Add role controller and tests

5e0a429

Merge branch 'develop' into feature/roles

10623bb

BrunoRosendo requested review from a team and removed request for a team April 5, 2023 15:29

LuisDuarte1 added 2 commits April 12, 2023 13:56

Add more tests and refactor some endpoints

c1cd182

Change endpoints and create permissionsDto to keep API more semantic

4840c1b

Add documentation and refactor tests

a17fe90

BrunoRosendo self-requested a review May 3, 2023 15:37

LuisDuarte1 requested review from limwa, bdmendes and MRita443 May 3, 2023 15:38

BrunoRosendo requested changes May 15, 2023

View reviewed changes

LuisDuarte1 and others added 4 commits June 21, 2023 10:42

[no ci] Apply suggestions from code review

a6d64c3

Co-authored-by: BrunoRosendo <[email protected]>

[no ci] Apply test files suggestions from code review

50faa4e

Co-authored-by: BrunoRosendo <[email protected]>

Merge remote-tracking branch 'origin/develop' into feature/roles

bae8512

first improvements to readability and consistency

09ee6c4

bdmendes reviewed Jul 3, 2023

View reviewed changes

src/main/kotlin/pt/up/fe/ni/website/backend/controller/RoleController.kt Show resolved Hide resolved

LuisDuarte1 added 2 commits July 5, 2023 14:35

make tests run and remove ordercolumn

28b4118

fix linting

81faf12

BrunoRosendo mentioned this pull request Jul 5, 2023

roles: manage role priority in each generation #172

Open

5 tasks

fix docs

b01bb25

LuisDuarte1 force-pushed the feature/roles branch from b1ee70c to b01bb25 Compare July 12, 2023 13:15

LuisDuarte1 requested review from limwa, BrunoRosendo and bdmendes July 19, 2023 11:36

BrunoRosendo linked an issue Jul 19, 2023 that may be closed by this pull request

projects: add roles across team members #48

Closed

limwa requested changes Jul 19, 2023

View reviewed changes

BrunoRosendo requested changes Jul 25, 2023

View reviewed changes

BrunoRosendo reviewed Jul 25, 2023

View reviewed changes

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt Outdated Show resolved Hide resolved

src/test/kotlin/pt/up/fe/ni/website/backend/utils/TestUtils.kt Show resolved Hide resolved

LuisDuarte1 added 2 commits July 26, 2023 15:16

make code suggestions

b1c05c4

remove redudant permissions call

62907e4

LuisDuarte1 force-pushed the feature/roles branch from 4c164c6 to 62907e4 Compare July 26, 2023 14:29

fix tests

95dc712

LuisDuarte1 requested review from BrunoRosendo and limwa July 26, 2023 15:04

LuisDuarte1 mentioned this pull request Jul 26, 2023

Create a seperate page for documenting the permissions #182

Open

limwa approved these changes Aug 5, 2023

View reviewed changes

LuisDuarte1 added 3 commits August 16, 2023 11:30

Add role update endpoint

6dcb39e

Merge remote-tracking branch 'origin/develop' into feature/roles

5781aca

update tests because of merge

cbac9ff

BrunoRosendo reviewed Aug 16, 2023

View reviewed changes

src/main/kotlin/pt/up/fe/ni/website/backend/service/RoleService.kt Outdated Show resolved Hide resolved

make updating logic simpler

100836c

BrunoRosendo approved these changes Aug 16, 2023

View reviewed changes

LuisDuarte1 merged commit 4d457a4 into develop Aug 16, 2023

LuisDuarte1 deleted the feature/roles branch August 16, 2023 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Role management endpoints #145

Role management endpoints #145

LuisDuarte1 commented Apr 5, 2023

github-actions bot commented Apr 5, 2023

codecov-commenter commented Apr 5, 2023 •

edited by codecov bot

Loading

github-actions bot commented Apr 5, 2023

BrunoRosendo commented Apr 16, 2023

github-actions bot commented Apr 26, 2023

BrunoRosendo left a comment

github-actions bot commented Jul 5, 2023

limwa left a comment

BrunoRosendo commented Jul 25, 2023

BrunoRosendo left a comment

BrunoRosendo Jul 25, 2023

BrunoRosendo Jul 25, 2023

LuisDuarte1 Jul 26, 2023

github-actions bot commented Jul 26, 2023

limwa left a comment

BrunoRosendo commented Aug 8, 2023

github-actions bot commented Aug 16, 2023

LuisDuarte1 commented Aug 16, 2023 •

edited

Loading

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

Role management endpoints #145

Role management endpoints #145

Conversation

LuisDuarte1 commented Apr 5, 2023

github-actions bot commented Apr 5, 2023

codecov-commenter commented Apr 5, 2023 • edited by codecov bot Loading

Codecov Report

github-actions bot commented Apr 5, 2023

BrunoRosendo commented Apr 16, 2023

github-actions bot commented Apr 26, 2023

BrunoRosendo left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2023

limwa left a comment

Choose a reason for hiding this comment

BrunoRosendo commented Jul 25, 2023

BrunoRosendo left a comment

Choose a reason for hiding this comment

BrunoRosendo Jul 25, 2023

Choose a reason for hiding this comment

BrunoRosendo Jul 25, 2023

Choose a reason for hiding this comment

LuisDuarte1 Jul 26, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 26, 2023

limwa left a comment

Choose a reason for hiding this comment

BrunoRosendo commented Aug 8, 2023

github-actions bot commented Aug 16, 2023

LuisDuarte1 commented Aug 16, 2023 • edited Loading

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

codecov-commenter commented Apr 5, 2023 •

edited by codecov bot

Loading

LuisDuarte1 commented Aug 16, 2023 •

edited

Loading