Skip to content

If merged, this PR will Remove a blank string that is causing exglobal_cleanup.sh to crash #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

andytangborn
Copy link
Contributor

@andytangborn andytangborn commented Jun 11, 2025

Description

This draft PR is a potential fix to the crashing of the cleanup step for GCAFS. The problem is caused by an empty string and this fix checks for the empty string and changes the script to leave it out.

Resolves #3786

Type of change

  • Bug fix

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Cycling many days on gaea.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary


if [[ -n "$find_exclude_string" ]]; then
# shellcheck disable=SC2086
eval find "${directory}" -type f -not \( ${find_exclude_string} \) -ignore_readdir_race -delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is eval added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from trying to debug. Probably not needed.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right general idea, but there are changes here that shouldn't be made like extra spaces, prints, and we need to keep all the shellcheck directives. Also, we will need to clean up the PR title/description.

@andytangborn andytangborn changed the title Potential fix for exglobal_cleanup.sh If merged, this PR will Remove a blank string that is causing exglobal_cleanup.sh to crash Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCAFS failing in gcdas_cleanup after 5 cycles.
2 participants