-
Notifications
You must be signed in to change notification settings - Fork 194
If merged, this PR will Remove a blank string that is causing exglobal_cleanup.sh to crash #3791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
scripts/exglobal_cleanup.sh
Outdated
|
||
if [[ -n "$find_exclude_string" ]]; then | ||
# shellcheck disable=SC2086 | ||
eval find "${directory}" -type f -not \( ${find_exclude_string} \) -ignore_readdir_race -delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is eval
added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover from trying to debug. Probably not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the right general idea, but there are changes here that shouldn't be made like extra spaces, prints, and we need to keep all the shellcheck directives. Also, we will need to clean up the PR title/description.
Description
This draft PR is a potential fix to the crashing of the cleanup step for GCAFS. The problem is caused by an empty string and this fix checks for the empty string and changes the script to leave it out.
Resolves #3786
Type of change
Change characteristics
How has this been tested?
Cycling many days on gaea.
Checklist