-
Notifications
You must be signed in to change notification settings - Fork 194
Cleanup of symlinks for wxflow, etc., use of DATAoutput for model, update to triggers for wavepost jobs, and other misc. stuff #3833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
seconds=$(to_seconds "${vdate:8:2}0000") # convert HHMMSS to seconds | ||
ww3_restart_ufs_file="ufs.cpld.ww3.r.${vdate:0:4}-${vdate:4:2}-${vdate:6:2}-${seconds}.nc" | ||
ww3_netcdf_restart_file="${vdate:0:8}.${vdate:8:2}0000.restart.ww3.nc" | ||
${NLN} "${DATArestart}/WW3_RESTART/${ww3_netcdf_restart_file}" "${ww3_restart_ufs_file}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This portion of the code changed file formats from how the model is writing it out to the more readable YYYYMMDD.HH0000.restart.ww3.nc file name structure. I think we might need additional changes if this is removed, but maybe I'm not thinking through everything?
Do you have output of the extended S2SW test on WCOSS2 and/or the low res gfs cycled test so I can take a look at the output/logs or do I need to run these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running tests on Gaea C6. The logs for low res gfs cycled test will drop into /gpfs/f6/drsa-precip3/world-shared/Rahul.Mahajan/RUNTESTS/COMROOT/C96C48mx500_S2SW_cyc_gfs_tlc
. Feel free to look around and let me know if you find something out of place. I too, will keep an eye.
I removed this portion of the code because the model is now configured to write the WW3 restarts directly into DATArestart/WW3_RESTART
instead of in DATA
and then linking the restart file from DATA
into DATArestart/WW3_RESTART
It is possible that the model in segment 2 (or RERUN=YES
) needs to know what the right restart filename for WW3 is. As soon as my tests conclude, I will know that and will make a fix if one is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/NOAA-EMC/global-workflow/blob/develop/ush/forecast_det.sh#L101-L106 uses the more readable (my preferred) naming convention of the WW3 restart files.
This also uses the more readable format of restarts: https://github.com/NOAA-EMC/global-workflow/blob/develop/ush/forecast_postdet.sh#L501-L530
The code section above these lines also wouldn't work depending on if it's a re-run or you are copying to COM.
Looks good but needs more descriptive title |
That was just a little joke from the DA team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like the consolidation of those wavepost job definitions. Thanks @aerorahul !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to TLC
Description
This PR collects a few things. Specifically it:
wxflow
and relies on the setting ofPYTHONPATH
ifwxflow
is not available as an importable module. This will streamline whenwxflow
is part of a virtualenv or loaded via spack-stacksoca
andufsda
intoush/python
which is added toPYTHONPATH
. This applies consistency for all importable python modulesDATAoutput
for writing model output into. In particular, it creates and writes toFV3ATM_OUTPUT
,MOM6_OUTPUT
,CICE_OUTPUT
andWW3_OUTPUT
. In addition, WW3 restarts are written toWW3_RESTART
log.points
andlog.wave_grid
files for triggering wave post-processing jobs instead of binary output from the next forecast output time.Type of change
Change characteristics
How has this been tested?
Ongoing on GaeaC6
Checklist