Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create optional build for user-contributed code #332

Merged
merged 40 commits into from
Mar 31, 2025

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

@AlysonStahl-NOAA AlysonStahl-NOAA commented Feb 28, 2025

Part of #206

This PR sets up the build structure for user-contributed code in the "extra" subdirectory, starting with code that enables MySQL compatibility.

@AlysonStahl-NOAA AlysonStahl-NOAA changed the title Move user contributed code to "extra" subdirectory and build with BUILD_EXTRA=ON Create optional build for user-contributed code Feb 28, 2025
@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review March 24, 2025 18:47
@AlexanderRichert-NOAA
Copy link
Contributor

Is the idea that users will contribute code that lives in the "extra/" directory? If so then I don't know if it should necessarily get tested in CI, depending on how much work you foresee that being to maintain.

@AlysonStahl-NOAA
Copy link
Collaborator Author

Is the idea that users will contribute code that lives in the "extra/" directory? If so then I don't know if it should necessarily get tested in CI, depending on how much work you foresee that being to maintain.

Yes and the idea the user contributed code won't be tested. The test script I set up just checks that the functions are added to function list if the build option is turned on, but the code itself isn't tested.

I mostly created the test for myself while setting this up, but I wanted a test that would break if contributors don't follow the necessary steps. However, they would also need to update the test as well and we can look for this in code reviews anyways.

I'll just remove the tests.

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit 03c7a2f into NOAA-EMC:develop Mar 31, 2025
20 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_extra2 branch March 31, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants