Bugfix for mixing up Rho0 and rho_ref in Boussinesq PGF
#837
+54
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I_Rho = 1.0/rho_0 is never used and therefore removed.
This new parameter addresses a bug in Boussinesq finite volume pressure gradient forces (MOM_PressureForce_FV) that the mean seawater density Rho_0 and reference density Rho_ref are used incorrectly in several instances. It should be noted that by default Rho_ref is Rho_0 and Rho_ref is rarely set to other than Rho_0.
herrwang0
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in Boussinesq finite volume pressure gradient force that
GV%Rho0, mean seawater density andCS%Rho0, reference density are incorrectly interchanged in a number of instances. The bug probably has zero effect on any existing runs, as I am unaware of cases whereRHO_PGF_REFis set different fromRHO_0, otherwise, this bug would have been detected. So the fix here is just for future-proof purpose.RHO_PGF_REF_BUGis added.CS%Rho0is renamed toCS%rho_reffor clarification.GxRho_refis added to distinguish fromGxRho0.GxRho_refis used to offset reference density in interface heights inpa. AndGxRho0is used to calculate surface pressure. PreviouslyGxRho0was incorrectly using reference densityrho_ref(i.e.CS%Rho0).rho_refinstead ofGV%rho0. Two local variablesrho0_int_densityandrho0_set_pbceare added to maintain and fix this issue.This PR does not change answers.
054354f: Remove unused variable
I_Rhoin threeint_density_dzsubroutines93a86dc: Add runtime flag
RHO_PGF_REF_BUG