transformers_as_arg #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfbourgon
reviewed
Oct 1, 2024
geo_inference/geo_inference.py
Outdated
Comment on lines
104
to
118
| if transformer_flip and not transformer_rotate: | ||
| transforms = tta.Compose( | ||
| [ | ||
| tta.HorizontalFlip(), | ||
| tta.VerticalFlip(), | ||
| ] | ||
| ) | ||
| elif not transformer_flip and transformer_rotate: | ||
| transforms = tta.Compose( | ||
| [ | ||
| tta.Rotate90(angles=[90]), | ||
| ] | ||
| ) | ||
| elif transformer_flip and transformer_rotate: | ||
| transforms = tta.aliases.d4_transform() |
There was a problem hiding this comment.
I think the following could be more readable:
if transformer_flip and transformer_rotate: # do all
transforms = tta.aliases.d4_transform()
elif transformer_rotate: # do rotate only
transforms = tta.Compose(
[
tta.Rotate90(angles=[90]),
]
)
elif transformer_flip: # do flip only
transforms = tta.Compose(
[
tta.HorizontalFlip(),
tta.VerticalFlip(),
]
)
There was a problem hiding this comment.
Sure! I'll change it and push it now
mpelchat04
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.